[M3] /api/health hardcodes woo_reachable: false and the version string is still 0.5.0-m3-s0 #84

New Issue

2026-09-20T18:16:48Z

grokbot_ty commented

2026-09-20 18:16:48 +00:00

Summary

GET /api/health reports "woo_reachable": false unconditionally, with an S0-era comment promising S4 would implement the real check. S4 shipped. Any monitor or uptime check reading this endpoint gets a permanent false signal, and the app's own version string never left S0.

Found in a read-only review of main @ b99cbdf (2026-09-20). 63 backend tests pass and both docs gates pass at that commit; these are gaps the green suite does not cover.

Observed evidence

backend/app.py:164-168:

return {
    "status": "ok",
    "version": __version__,
    "woo_reachable": False,  # S0 stub; S4 will implement real check
}

backend/app.py:28: __version__ = "0.5.0-m3-s0". backend/app.py:1-6 still describes the module as "Minimal, no S1+".

Acceptance

Either implement the check (reuse the SETTINGS-40/test-woo path with a cheap read), or drop the field from the payload — a health field that is always false is worse than an absent one.
If a live probe is added, it must not turn health into a store dependency: a store outage stays a signal, not a failed health check (APP-30/APP-45 gate health on storage only).
Version reflects the shipped milestone.

## Summary `GET /api/health` reports `"woo_reachable": false` unconditionally, with an S0-era comment promising S4 would implement the real check. S4 shipped. Any monitor or uptime check reading this endpoint gets a permanent false signal, and the app's own version string never left S0. Found in a read-only review of `main` @ `b99cbdf` (2026-09-20). 63 backend tests pass and both docs gates pass at that commit; these are gaps the green suite does not cover. ## Observed evidence `backend/app.py:164-168`: ```python return { "status": "ok", "version": __version__, "woo_reachable": False, # S0 stub; S4 will implement real check } ``` `backend/app.py:28`: `__version__ = "0.5.0-m3-s0"`. `backend/app.py:1-6` still describes the module as "Minimal, no S1+". ## Acceptance - Either implement the check (reuse the `SETTINGS-40`/`test-woo` path with a cheap read), or drop the field from the payload — a health field that is always false is worse than an absent one. - If a live probe is added, it must not turn health into a store dependency: a store outage stays a signal, not a failed health check (`APP-30`/`APP-45` gate health on storage only). - Version reflects the shipped milestone. ## Related - Requirements: APP-30, APP-45, SETTINGS-40, OPS-25

grokbot_ty referenced this issue from a commit

2026-09-21 08:32:29 +00:00

fix(backend): #84 real woo_reachable, #83 reject unknown fields, #82 live taxonomy in stale_field, #80 persist review overrides

grokbuild_ty referenced this issue from a commit

2026-09-21 19:51:29 +00:00

fix(m3): Option A must-fix #79 #82 #83 #84 #89 #98

grokbot_ty referenced this issue from a commit

2026-09-21 19:55:28 +00:00

fix(m3): Option A must-fix #79 #82 #83 #84 #89 #98

grokbot_ty closed this issue

2026-09-21 19:59:38 +00:00

grokbot_ty referenced this issue

2026-09-21 19:59:53 +00:00

[M3] Publish path omits User-Agent and reports a WAF 403 as retryable — the b99cbdf fix does not cover product create #79

grokbot_ty referenced this issue

2026-09-21 19:59:54 +00:00

[M3] stale_field error returns the submitted value as current_options instead of the live taxonomy options (PUBLISH-20) #82

grokbot_ty referenced this issue

2026-09-21 19:59:55 +00:00

[M3] POST /slabs: an extra payload key breaks the INSERT binding count; unvalidated columns/values raise raw DB errors instead of 400 #83

grokbot_ty commented

2026-09-21 19:59:55 +00:00

Closed by M3 Option A: main 0c00d25 + UAT QUALITY-110 evidence.

Deploy: version 0.5.0-m3, woo_reachable: true
test-woo ok (taxonomy synced)
Inference off for the walk; SLAB-UAT-125846 → Woo draft product_id=48147 matching reviewed ready set
Must-fix covered: #79 UA/403, #82 live current_options, #83 unknown-field/taxonomy 4xx, #84 health probe+version, #89 Create title/short from review, #98 live-edge from synced edge term + attr slug resolve

Closed by M3 Option A: main `0c00d25` + UAT QUALITY-110 evidence. - Deploy: version `0.5.0-m3`, `woo_reachable: true` - `test-woo` ok (taxonomy synced) - Inference off for the walk; **SLAB-UAT-125846** → Woo draft `product_id=48147` matching reviewed ready set - Must-fix covered: #79 UA/403, #82 live `current_options`, #83 unknown-field/taxonomy 4xx, #84 health probe+version, #89 Create title/short from review, #98 live-edge from synced edge term + attr slug resolve

grokbot_ty referenced this issue

2026-09-21 19:59:55 +00:00

Bug: Call 1 + human lock of taxonomy must complete before deterministic title/short desc #89

grokbot_ty referenced this issue

2026-09-21 19:59:56 +00:00

Code review - review.py directly violates the spec requirements that all metadata values derive from the woo sync per caching rules, and are never hardcoded #98

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Ty_Tech/SlabUploader#84