[M3] stale_field error returns the submitted value as current_options instead of the live taxonomy options (PUBLISH-20) #82

New Issue

2026-09-20T18:16:48Z

grokbot_ty commented

2026-09-20 18:16:48 +00:00

Summary

PUBLISH-20 requires a stale value to produce a field-level error with the current options. The API returns the value the client just submitted in that slot, so a UI rendering detail.current_options would present the rejected value as if it were the option list.

Found in a read-only review of main @ b99cbdf (2026-09-20). 63 backend tests pass and both docs gates pass at that commit; these are gaps the green suite does not cover.

Observed evidence

backend/slabs.py:148-158:

if not _check_taxonomy(conn, table, val):
    return _err("stale_field", f"{field} not in current taxonomy",
                {"current_options": val}, status=422)   # val == the submitted value

Reproduction:

PUT /api/v1/slabs/s1  {"client_rev": 1, "edge_type_term_id": 999}
-> 422 {"error": {"code": "stale_field",
            "message": "edge_type_term_id not in current taxonomy",
            "detail": {"current_options": 999}}}

999 is the client's own input echoed back. The live options live in woo_attribute_terms / woo_categories / woo_tags — the same tables _check_taxonomy just queried.

Acceptance

detail.current_options carries the actual current term/category/tag list for that field (id + name), read from the taxonomy tables.
A test asserts the returned options are the seeded taxonomy rows and that the submitted bogus value is not among them.
The field name in the message maps to an owner-readable label, not a column name (QUALITY-120).

## Summary `PUBLISH-20` requires a stale value to produce a field-level error **with the current options**. The API returns the value the client just submitted in that slot, so a UI rendering `detail.current_options` would present the rejected value as if it were the option list. Found in a read-only review of `main` @ `b99cbdf` (2026-09-20). 63 backend tests pass and both docs gates pass at that commit; these are gaps the green suite does not cover. ## Observed evidence `backend/slabs.py:148-158`: ```python if not _check_taxonomy(conn, table, val): return _err("stale_field", f"{field} not in current taxonomy", {"current_options": val}, status=422) # val == the submitted value ``` Reproduction: ``` PUT /api/v1/slabs/s1 {"client_rev": 1, "edge_type_term_id": 999} -> 422 {"error": {"code": "stale_field", "message": "edge_type_term_id not in current taxonomy", "detail": {"current_options": 999}}} ``` `999` is the client's own input echoed back. The live options live in `woo_attribute_terms` / `woo_categories` / `woo_tags` — the same tables `_check_taxonomy` just queried. ## Acceptance - `detail.current_options` carries the actual current term/category/tag list for that field (id + name), read from the taxonomy tables. - A test asserts the returned options are the seeded taxonomy rows and that the submitted bogus value is **not** among them. - The field name in the message maps to an owner-readable label, not a column name (QUALITY-120). ## Related - `#77` (stale-field recovery at publish UI), `#45` - Requirements: PUBLISH-20, REVIEW-35, QUALITY-120

grokbot_ty referenced this issue from a commit

2026-09-21 08:32:29 +00:00

fix(backend): #84 real woo_reachable, #83 reject unknown fields, #82 live taxonomy in stale_field, #80 persist review overrides

grokbuild_ty referenced this issue from a commit

2026-09-21 19:51:29 +00:00

fix(m3): Option A must-fix #79 #82 #83 #84 #89 #98

grokbot_ty referenced this issue from a commit

2026-09-21 19:55:28 +00:00

fix(m3): Option A must-fix #79 #82 #83 #84 #89 #98

grokbot_ty closed this issue

2026-09-21 19:59:36 +00:00

grokbot_ty referenced this issue

2026-09-21 19:59:53 +00:00

[M3] Publish path omits User-Agent and reports a WAF 403 as retryable — the b99cbdf fix does not cover product create #79

grokbot_ty commented

2026-09-21 19:59:54 +00:00

Closed by M3 Option A: main 0c00d25 + UAT QUALITY-110 evidence.

Deploy: version 0.5.0-m3, woo_reachable: true
test-woo ok (taxonomy synced)
Inference off for the walk; SLAB-UAT-125846 → Woo draft product_id=48147 matching reviewed ready set
Must-fix covered: #79 UA/403, #82 live current_options, #83 unknown-field/taxonomy 4xx, #84 health probe+version, #89 Create title/short from review, #98 live-edge from synced edge term + attr slug resolve

Closed by M3 Option A: main `0c00d25` + UAT QUALITY-110 evidence. - Deploy: version `0.5.0-m3`, `woo_reachable: true` - `test-woo` ok (taxonomy synced) - Inference off for the walk; **SLAB-UAT-125846** → Woo draft `product_id=48147` matching reviewed ready set - Must-fix covered: #79 UA/403, #82 live `current_options`, #83 unknown-field/taxonomy 4xx, #84 health probe+version, #89 Create title/short from review, #98 live-edge from synced edge term + attr slug resolve

grokbot_ty referenced this issue

2026-09-21 19:59:55 +00:00

[M3] POST /slabs: an extra payload key breaks the INSERT binding count; unvalidated columns/values raise raw DB errors instead of 400 #83

grokbot_ty referenced this issue

2026-09-21 19:59:55 +00:00

[M3] /api/health hardcodes woo_reachable: false and the version string is still 0.5.0-m3-s0 #84

grokbot_ty referenced this issue

2026-09-21 19:59:55 +00:00

Bug: Call 1 + human lock of taxonomy must complete before deterministic title/short desc #89

grokbot_ty referenced this issue

2026-09-21 19:59:56 +00:00

Code review - review.py directly violates the spec requirements that all metadata values derive from the woo sync per caching rules, and are never hardcoded #98