Bug: overlay dims ignore configured length axis (#69 regression) #70

New Issue

2026-09-16T04:33:00Z

grokbot_ty commented

2026-09-16 04:33:00 +00:00

Fail (Ty phone UAT attachment)

Dimension overlay does not follow the configured M1 length axis. Width looks screen-horizontal; length cuts at the wrong angle.

Root cause

Issue #69 tip-snap placed length ends by translating tip pixels with screen-only dx or dy. That makes the length line not parallel to the approved axis unit.

Product state induced

Length dim parallel to approved length axis, beside wood (axis-right), endpoints at robust wood tip axial stations.
Width dims perpendicular to that axis; arrows on wood edges.
Keep #69 robust tip percentiles; remove screen-axis tip translation hack.

Done when

TDD green + overnight :10881 redeploy; length || axis, widths ⊥ axis on a tilted slab.

## Fail (Ty phone UAT attachment) Dimension overlay does not follow the configured M1 length axis. Width looks screen-horizontal; length cuts at the wrong angle. ## Root cause Issue #69 tip-snap placed length ends by translating tip pixels with screen-only dx or dy. That makes the length line not parallel to the approved axis unit. ## Product state induced - Length dim parallel to approved length axis, beside wood (axis-right), endpoints at robust wood tip axial stations. - Width dims perpendicular to that axis; arrows on wood edges. - Keep #69 robust tip percentiles; remove screen-axis tip translation hack. ## Done when TDD green + overnight :10881 redeploy; length || axis, widths ⊥ axis on a tilted slab.

grokbot_ty added this to the M2 Photos milestone 2026-09-16 04:33:00 +00:00

grokbot_ty referenced this issue from a commit

2026-09-16 04:35:57 +00:00

test(photos): length/width dims follow approved axis (#70)

grokbot_ty referenced this issue from a commit

2026-09-16 04:35:57 +00:00

fix(photos): length dim parallel to approved axis (#70)

grokbot_ty referenced this issue from a commit

2026-09-16 04:37:03 +00:00

test(photos): refresh e2e evidence after axis parallel fix (#70)

grokbot_ty commented

2026-09-16 04:38:01 +00:00

Fixed on `m2-ds`

SHAs

dc19cff — test(photos): length/width dims follow approved axis (#70)
6d182db — fix(photos): length dim parallel to approved axis (#70)
2be2e7d — test(photos): refresh e2e evidence after axis parallel fix (#70)

Geometric fix
Removed #69 screen-only tip translation (dx/dy sharing tip X or Y). Length ends are centerline tip stations (robust 0.2%/99.8% axial percentiles) offset by pure axis-right (rx,ry)*outward, so length stays || approved (ux,uy). Widths already ⊥ via (rx,ry).

Tests

npm test: 76 pass (failing #70 parallel-axis test first, then green after fix; #69 adapted to axial stations)
Playwright e2e: 1 passed; artifacts refreshed

Deploy

slabuploader-m2-overnight on 0.0.0.0:10881 → curl 200
Bundle assets/index-6-_sauWM.js
Ty local :18080 untouched; :10880 not listening

## Fixed on `m2-ds` **SHAs** - `dc19cff` — `test(photos): length/width dims follow approved axis (#70)` - `6d182db` — `fix(photos): length dim parallel to approved axis (#70)` - `2be2e7d` — `test(photos): refresh e2e evidence after axis parallel fix (#70)` **Geometric fix** Removed #69 screen-only tip translation (`dx`/`dy` sharing tip X or Y). Length ends are centerline tip stations (robust 0.2%/99.8% axial percentiles) offset by pure axis-right `(rx,ry)*outward`, so length stays || approved `(ux,uy)`. Widths already ⊥ via `(rx,ry)`. **Tests** - `npm test`: 76 pass (failing #70 parallel-axis test first, then green after fix; #69 adapted to axial stations) - Playwright e2e: 1 passed; artifacts refreshed **Deploy** - `slabuploader-m2-overnight` on `0.0.0.0:10881` → curl **200** - Bundle `assets/index-6-_sauWM.js` - Ty local `:18080` untouched; `:10880` not listening

grokbot_ty closed this issue

2026-09-16 04:38:11 +00:00

grokbot_ty referenced this issue

2026-09-16 04:56:05 +00:00

Bug: overlay dims too long past wood; text inconsistent/clipped #71

~~grokbot_ty referenced this issue 2026-09-16 05:04:45 +00:00~~

bug(photos): overlay dims not following set axis — EXIF Image vs createImageBitmap (#72) #72

Sign in to join this conversation.