Bug: length dim arrows overshoot wood footprint tips #69

New Issue

2026-09-16T02:15:12Z

grokbot_ty commented

2026-09-16 02:15:12 +00:00

Fail (Ty UAT)

Middle Photos-ready card: length dimension arrowheads extend above and below the wood footprint. Width arrows tip-to-tip on wood is OK; length overshoot is the fail. Width labels may still sit on the wood — keep them axis-left fully off the slab.

Likely cause

buildOverlayPlan places length ends at mask-span tips offset by axis-right (rx,ry)*outward. If axis isn't perfectly vertical, that offset has a y component, so screen-space ends move past the wood's visual tip.

Required

Length endpoints at mask/wood tips along approved axis (same axial stations). Arrowheads level with wood tip-to-tip.
Prefer classic dimensioning: length line parallel beside wood; measured span = wood tip-to-tip.
Width arrows still touch left/right wood edges; width labels fully left of wood.

## Fail (Ty UAT) Middle Photos-ready card: length dimension arrowheads extend above and below the wood footprint. Width arrows tip-to-tip on wood is OK; length overshoot is the fail. Width labels may still sit on the wood — keep them axis-left fully off the slab. ## Likely cause `buildOverlayPlan` places length ends at mask-span tips offset by axis-right `(rx,ry)*outward`. If axis isn't perfectly vertical, that offset has a **y component**, so screen-space ends move past the wood's visual tip. ## Required - Length endpoints at mask/wood tips along approved axis (same axial stations). Arrowheads level with wood tip-to-tip. - Prefer classic dimensioning: length line parallel beside wood; measured span = wood tip-to-tip. - Width arrows still touch left/right wood edges; width labels fully left of wood.

grokbot_ty added this to the M2 Photos milestone 2026-09-16 02:15:12 +00:00

grokbot_ty commented

2026-09-16 02:29:42 +00:00

Fixed on m2-ds.

Root cause: (1) Length ends used tip pixels + raw outward / axis-right offset so a tilted axis or left-edge tip put the dim through/past the wood; (2) absolute mask min/max tips picked outlier mask specks past the visible footprint.

Fix: Robust 0.2%/99.8% axial tip stations; translate tip pixels by a common screen-axis offset matching classic axis-right clearance (span = tip-to-tip, arrowheads level with tips). Width labels get more clearance + textAlign away from wood.

Commits: 415158d test, 05447c9 fix. Overnight redeployed slabuploader-m2-overnight on :10881.

Fixed on m2-ds. **Root cause:** (1) Length ends used tip pixels + raw `outward` / axis-right offset so a tilted axis or left-edge tip put the dim through/past the wood; (2) absolute mask min/max tips picked outlier mask specks past the visible footprint. **Fix:** Robust 0.2%/99.8% axial tip stations; translate tip pixels by a common screen-axis offset matching classic axis-right clearance (span = tip-to-tip, arrowheads level with tips). Width labels get more clearance + textAlign away from wood. **Commits:** `415158d` test, `05447c9` fix. Overnight redeployed `slabuploader-m2-overnight` on :10881.

grokbot_ty referenced this issue from a commit

2026-09-16 02:29:46 +00:00

test(photos): length dim snaps to wood tips (#69)

grokbot_ty referenced this issue from a commit

2026-09-16 02:29:46 +00:00

fix(photos): length dim snaps to wood footprint (#69)

grokbot_ty closed this issue

2026-09-16 02:29:48 +00:00

grokbot_ty referenced this issue

2026-09-16 04:33:00 +00:00

Bug: overlay dims ignore configured length axis (#69 regression) #70

grokbot_ty referenced this issue