Ty_Tech/SlabUploader
6
0
Fork 0
Code Issues 15 Pull Requests Actions Packages Projects Releases Wiki Activity

bug(mask): sensitivity too aggressive — live edge gone at lowest setting (#74) #74

New Issue
Closed
opened 2026-09-16 05:14:49 +00:00 by grokbot_ty · 1 comment
grokbot_ty commented 2026-09-16 05:14:49 +00:00
Owner
Copy Link
Copy Source

Ty confirmed M2 complete (chat). Closing after UAT.

Ty confirmed M2 complete (chat). Closing after UAT.
grokbot_ty added this to the M2 Photos milestone 2026-09-16 05:14:49 +00:00
grokbot_ty commented 2026-09-16 15:19:33 +00:00
Author
Owner
Copy Link
Copy Source

Implemented + deployed for Ty re-UAT (leaving OPEN)

Root cause confirmed: black-sheet lum < 40 + 140*(s/100) classified dark bark/live-edge pixels as sheet even at sensitivity 0.

Fix: 03d3fcf4607a2d17d645f938bbf1d428a5abfaf4 on m2-ds

  • extracted blackKeep / greenKeep / auto-pick into testable frontend/src/mask/sheetKeep.ts; worker imports them
  • black floor is now luminance 10 at s=0, preserving dark wood (~25–50) while still removing near-black sheet
  • black match widens monotonically to luminance 150 at s=100
  • green s=0 is likewise conservative and its match widens monotonically toward s=100
  • tests cover dark wood, near-black sheet, sensitivity monotonicity, bright wood, mild green cast, and strong green sheet

Validation: 88/88 unit tests pass; production TypeScript/Vite build passes.

Overnight redeploy (only :10881):

  • container slabuploader-m2-overnight
  • image slabuploader-m2:overnight (sha256:4fee144ddb73e4acb406ec8ed9ff32a42d283caeabe9846afe3ce93b2443f3e9)
  • curl http://100.64.0.9:10881/ → HTTP 200
  • Ty local slabuploader-m1 remains on :18080; :10880 untouched

Ty re-UAT ask

On the black-sheet live-edge slab, set sensitivity to 0 and confirm dark bark/live edge stays selected while the near-black sheet is removed. Then raise sensitivity and confirm sheet removal widens progressively. Leave open until PASS/FAIL.

## Implemented + deployed for Ty re-UAT (leaving OPEN) **Root cause confirmed:** black-sheet `lum < 40 + 140*(s/100)` classified dark bark/live-edge pixels as sheet even at sensitivity 0. **Fix:** `03d3fcf4607a2d17d645f938bbf1d428a5abfaf4` on `m2-ds` - extracted `blackKeep` / `greenKeep` / auto-pick into testable `frontend/src/mask/sheetKeep.ts`; worker imports them - black floor is now luminance 10 at s=0, preserving dark wood (~25–50) while still removing near-black sheet - black match widens monotonically to luminance 150 at s=100 - green s=0 is likewise conservative and its match widens monotonically toward s=100 - tests cover dark wood, near-black sheet, sensitivity monotonicity, bright wood, mild green cast, and strong green sheet **Validation:** 88/88 unit tests pass; production TypeScript/Vite build passes. **Overnight redeploy (only `:10881`):** - container `slabuploader-m2-overnight` - image `slabuploader-m2:overnight` (`sha256:4fee144ddb73e4acb406ec8ed9ff32a42d283caeabe9846afe3ce93b2443f3e9`) - `curl http://100.64.0.9:10881/` → **HTTP 200** - Ty local `slabuploader-m1` remains on `:18080`; `:10880` untouched ### Ty re-UAT ask On the black-sheet live-edge slab, set sensitivity to 0 and confirm dark bark/live edge stays selected while the near-black sheet is removed. Then raise sensitivity and confirm sheet removal widens progressively. Leave open until PASS/FAIL.
Sign in to join this conversation.
m2-ds
Branches Tags
Labels
Clear labels
blocking
Blocks POC acceptance; must be resolved before merge
 docs
Documentation change required
 gate-b
Gate B sprint issue
 gate-c
Gate C sprint issue
 gc-seq-01
Serial order 01/6 in Gate C sprint
 gc-seq-02
Serial order 02/6 in Gate C sprint
 gc-seq-03
Serial order 03/6 in Gate C sprint
 gc-seq-04
Serial order 04/6 in Gate C sprint
 gc-seq-05
Serial order 05/6 in Gate C sprint
 gc-seq-06
Serial order 06/6 in Gate C sprint
 poc
POC post-Gate-C issue
 poc-seq-01
Serial order 01 in POC sprint
 poc-seq-02
Serial order 02 in POC sprint
 poc-seq-03
Serial order 03 in POC sprint
 poc-seq-04
Serial order 04 in POC sprint
 poc-seq-05
Serial order 05 in POC sprint
 poc-seq-06
Serial order 06 in POC sprint
 poc-seq-07
Serial order 07 in POC sprint
 poc-seq-08
Serial order 08 in POC sprint
 poc-seq-09
Serial order 09 in POC sprint
 poc-seq-10
Serial order 10 in POC sprint
 poc-seq-11
Serial order 11 in POC sprint
 poc-seq-12
Serial order 12 in POC sprint
 poc-seq-13
Serial order 13 in POC sprint
 poc-seq-14
Serial order 14 in POC sprint
 poc-seq-15
Serial order 15 in POC sprint
 poc-seq-16
Serial order 16 in POC sprint
 poc-seq-17
Serial order 17 in POC sprint
 poc-seq-18
Serial order 18 in POC sprint
 poc-seq-19
Serial order 19 in POC sprint
 poc-seq-20
Serial order 20 in POC sprint
 post-launch
Deferred to post-launch / V1.5+
 seq-01
Serial order 1/10 in Gate B sprint
 seq-02
Serial order 2/10 in Gate B sprint
 seq-03
Serial order 3/10 in Gate B sprint
 seq-04
Serial order 4/10 in Gate B sprint
 seq-05
Serial order 5/10 in Gate B sprint
 seq-06
Serial order 6/10 in Gate B sprint
 seq-07
Serial order 7/10 in Gate B sprint
 seq-08
Serial order 8/10 in Gate B sprint
 seq-09
Serial order 9/10 in Gate B sprint
 seq-10
Serial order 10/10 in Gate B sprint
No Label
Milestone
No items
No Milestone M2 Photos
Projects
Clear projects
No project
Assignees
Clear assignees
HA_Architect HA_Researcher Ty grokbot_ty grokbuild_ty tonyjbala (Tony Balascio)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Ty_Tech/SlabUploader#74
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?