From 8673ae0ecd182d0b94470ef3dcfee0e5d18207ee Mon Sep 17 00:00:00 2001 From: Ty Date: Fri, 25 Sep 2026 09:17:23 -0700 Subject: [PATCH] docs(m4): record #99 as-built and sweep stale draggable-tick refs (#99) --- .planning/milestones/v0.5/M4/goals.md | 26 ++++++++------ .planning/milestones/v0.5/M4/tasks.md | 51 +++++++++++++++++---------- deploy/INVENTORY.md | 30 ++++++++++++++++ 3 files changed, 79 insertions(+), 28 deletions(-) diff --git a/.planning/milestones/v0.5/M4/goals.md b/.planning/milestones/v0.5/M4/goals.md index 669fd89..ea15aaa 100644 --- a/.planning/milestones/v0.5/M4/goals.md +++ b/.planning/milestones/v0.5/M4/goals.md @@ -20,13 +20,18 @@ Raw runner evidence recorded; Ty owns gate exit (QUALITY-25/30). ## Goals (accepted direction) 1. **Stabilize + polish the M3 experience (A) — includes the #99 tape-line calibration (B).** - - **Tape-line calibration (#99):** replace the axis-rectangle calibration with a draggable - tape-line (black line + two rifle-scope end ticks). Declared length = distance between - ticks (owner-declared); scale = tick-pixel distance / declared length, no - `maskSpanAlong` check. New - requirement row(s); supersedes the projected-span length model in CAPTURE-60/75. The `m4` - branch already carries `crop_fill` + `TapePrototype.svelte` (`?tape-prototype`); M4 - promotes it from prototype to shipped. + - **Tape-line calibration (#99) — SHIPPED (as-built 2026-09-25, UAT signed off):** the + axis-rectangle calibration is replaced by a **fixed** black centre line with two end + ticks. The line is a stage fixture and is **never an owner input** (not draggable, not + focusable, not keyboard-nudgeable). The **source photo/slab is the only thing that + moves** — pan/zoom/tilt it until it lines up with the fixed line at the place the tape + measurement was taken. Declared Length = the real inches read off the tape, and the + fixed line represents that same length; scale = fixed-line pixel span / declared + Length, no `maskSpanAlong` check. The crop slider alone sets the line ends + (`crop_fill=90` ⇒ each end 5% from its edge). The earlier `?tape-prototype` sandbox, + `TapePrototype.svelte`, `frontend/src/png/crop.ts` and the `sveltedrag` dependency are + all superseded/removed. Requirement rows CAPTURE-170/175/75 carry the as-built; see + `tasks.md` T2 for detail. - **UX polish:** photo-picker look/feel (#91), photo filenames on submit (#92), capture gated on a tested Woo connection (#93), review UI is always the human-pick flow (#94), debug mode (#95), required-photo lock glyph (#100). (#96 Call 1/2 prompt viewer drops @@ -125,9 +130,10 @@ Raw runner evidence recorded; Ty owns gate exit (QUALITY-25/30). ## Acceptance criteria (draft) -1. **Tape-line calibration + M3 polish ship together (Goal 1):** the `?tape-prototype` - sandbox is replaced by the shipped calibration path (owner drags both ticks; declared - length = tick distance; no `maskSpanAlong` check), and the +1. **Tape-line calibration + M3 polish ship together (Goal 1):** the tape-line calibration + ships as a **fixed** centre line the owner pans/zooms/tilts the slab onto (line is never + an owner input; crop slider sets its ends; declared length = the real tape inches, and + the fixed line represents that same length; no `maskSpanAlong` check), and the M3 polish issues (#91–#100, excluding #96 which drops with Call 1) are closed with passing tests and raw runner evidence. 2. **The review flow is human-driven, thumb-first, and Call 1-free:** the owner can pick diff --git a/.planning/milestones/v0.5/M4/tasks.md b/.planning/milestones/v0.5/M4/tasks.md index 1e7287c..67cb3da 100644 --- a/.planning/milestones/v0.5/M4/tasks.md +++ b/.planning/milestones/v0.5/M4/tasks.md @@ -26,25 +26,40 @@ exit (QUALITY-30); agents record raw evidence, never declare green. - **Sequence:** first task of the sprint. - **Stop:** rows merged + gate green. **Evidence:** runner output. -### T2. #99 tape-line calibration (folded into G1) -- **Goal:** G1. **IDs:** CAPTURE (dimensions), REQS-50. **Issues:** #99. -- **Skills:** `systematic-debugging` (verify the prototype assumption), - `wireframe-review-iteration` (reference the overlay interaction), `svelte-core-bestpractices`. -- **Starting point:** `frontend/src/capture/TapePrototype.svelte` + `?tape-prototype` - sandbox on the `m4` branch; `docs/design/issue-99-tape-line-overlay.html` (approved - wireframe); `frontend/src/png/crop.ts` (projection logic). -- **Work:** promote the prototype to the shipped calibration path (owner drags both - ticks to the actual tape start/end; scale = tick-pixel distance / owner-declared - length — no `maskSpanAlong` check), delete the - sandbox + query-param gating, keep `crop_fill` (already landed in 818874e). - **Scope (Ty confirmed):** confined to the calibration step — the photos-ready - lineup (CAPTURE-130) stays as-is; #99 does not touch it. -- **Verification:** unit tests in `frontend/src/png/*` (tape geometry + tick-distance - scale math in photo px under pan/zoom/rotate), `tsc --noEmit`, - manual calibration on one slab at 375px. +### T2. #99 tape-line calibration (folded into G1) — AS-BUILT, shipped +- **Goal:** G1. **IDs:** CAPTURE-170, CAPTURE-175, CAPTURE-75. **Issues:** #99 (issue + body still describes the superseded draggable-tick model — this entry is the as-built). +- **Skills:** `systematic-debugging`, `svelte-core-bestpractices`, + `docker-uat-deploy` (isolate-and-verify the review preview). +- **As-built:** a **fixed** black centre line with two end ticks, drawn on the stage + fixture. The line is **never an owner input** — not draggable, not focusable, not + keyboard-nudgeable, and not part of the published pose. The **source photo/slab is the + only thing that moves**: drag to pan, wheel/pinch to zoom, the ↻ handle or arrow keys + (Shift = fine step) to tilt. The owner aligns the *slab* to the fixed line at the place + the tape measurement was taken. Typed Length is the real inches read off the tape, and + the fixed line represents that same length. Scale = fixed-line pixel span / declared + Length; `maskSpanAlong` is not the scale source. The crop slider is the **sole** control + of the line ends: `crop_fill=90` puts each end 5% from its corresponding edge. + Calibration rotation applies to the calibration clean PNG + overlay only; batch + siblings stay unrotated. +- **Superseded (do not restore):** draggable ticks; `TapePrototype.svelte` and the + `?tape-prototype` sandbox (both deleted); `frontend/src/png/crop.ts` (removed in + 6000ac2 — crop geometry now lives in `frontend/src/capture/tapeLine.ts` + `cropEnds(fillPercent)`); the `sveltedrag` dependency (404s on npm, never added). + The wireframe `docs/design/issue-99-tape-line-overlay.html` lives on branch + `issue-99-tape-line-overlay` (63b8879), not on `m4`. +- **Verification:** unit tests in `frontend/src/capture/tapeLine.test.ts` (ends fixed by + the crop slider, never an owner input) + `frontend/src/png/{inventory,overlay}.test.ts` + (calibration rotation reaches the calibration PNG/overlay only); `tsc --noEmit`; + `npm run build`; e2e `frontend/tests/e2e/tape-fixed-line.spec.ts` (no tick drag; a tick + drag behaves identically to a pan; ends follow the crop slider). - **Sequence:** parallel with T3–T5; no dependency on T1. -- **Stop:** prototype shipped, `?tape-prototype` removed, tests green. - **Evidence:** test output + a 375px capture of the calibration drag. +- **Stop:** SHIPPED. UAT-signed off by Ty 2026-09-25 on the M4 review preview + (`http://192.168.1.202:10883/?noload=1`, build `a756cf5`, branch `m4`). +- **Evidence:** `npm test` 102/102; requirements + coverage gates green; live e2e on the + deployed preview (0°/20° rotation produces differing clean PNG + overlay bytes); render + gate clean at 1440/768/375 with no overflow or clipped text; Ty's UAT sign-off. + **Not covered:** `svelte-check` still reports its known 42-error baseline. --- diff --git a/deploy/INVENTORY.md b/deploy/INVENTORY.md index 8251639..955478c 100644 --- a/deploy/INVENTORY.md +++ b/deploy/INVENTORY.md @@ -117,3 +117,33 @@ Do not put a host name in the product spec. GET slab/taxonomy/settings 200, review 200. - In-repo mock e2e (m3-create + photo-strip) 6/6 green against the same bundle hash before deploy. - Not done: commit/push of the import restore; Woo publish path not re-exercised this round. + +### 2026-09-25 08:57 PDT — M4 review preview: #99 fixed tape line + calibration rotation + +- Source: branch `m4`, commit **`a756cf5`** (`fix(m4): drop stale tick-nudge hint from tape page (#99)`), + pushed and verified on `origin/m4`. `matches HEAD`: **yes**. Preceding M4 commits on the same + branch: `1882fa3` (calibration tilt applied to the calibration PNG/overlay only) and + `7908a99` (tape calibration collapsed onto one page). +- Image `deploy-frontend:m4-a756cf5` (`sha256:26402a77…`) built on the 5060 from a clean release + archive, **not** from the `~/slab-deploy` greenfield checkout. Container `slabuploader-m4-review` + recreated on network `deploy_default`, host port `10883:80`, **zero mounts**. +- URL: http://192.168.1.202:10883/?noload=1 (M4 review only). **Not** `10881` — that is the old + `main` stack and has no Length page. `10882` is the API, not a UI. +- Bundle: `assets/index-BI2cLnOA.js`. Served bundle has **zero** `Drag the ticks` / + `nudge the last tick` strings and **does** contain the fixed-line hint. +- Main stack untouched: `:10881` and `:10882/api/health` both 200 throughout. +- Sample data preserved: **yes** — the review container is volume-free; the real DB was never + rebuilt or re-seeded. +- Live verification (deployed URL, real backend): the fixed line renders with both end ticks; + a drag starting on a tick behaves identically to a pan elsewhere (line does not move); the + crop slider moves the line ends; Length/Thickness → Calculate reaches Photos ready. A drag is + still allowed (that is the intended pan). +- Gates: `npm test` 102/102; `tsc --noEmit` clean; requirements + coverage gates green; + render gate clean at 1440/768/375 (no overflow, no clipped text, no page/console/HTTP errors). +- Regression guard proven to fail against pre-fix code, not just pass post-fix. +- Ty UAT sign-off: **length e2e signed off 2026-09-25**; minor bugs to be filed separately. +- Not done: `svelte-check` still reports its known 42-error baseline (no new error from this work); + `Calculate` (42px) and `Fit` (41px) are marginally under the 44px touch reference — pre-existing, + deliberately left for a separate decision; Gitea #99's **body** still describes the superseded + draggable-tick model (the as-built is recorded in `tasks.md` T2 and requirements rows + CAPTURE-170/175/75).