fix(review): Create desc gate does not require price
This commit is contained in:
@@ -17,7 +17,6 @@ const full = {
|
||||
figureTermIds: [328],
|
||||
gradeTermId: 342,
|
||||
moistureTermId: '326',
|
||||
price: '184.00',
|
||||
};
|
||||
|
||||
test('Create desc gate: full set passes; does not require description', () => {
|
||||
@@ -25,7 +24,13 @@ test('Create desc gate: full set passes; does not require description', () => {
|
||||
assert.deepEqual(missingCreateDesc(full), []);
|
||||
});
|
||||
|
||||
test('Create desc gate: lists each missing field; no description key', () => {
|
||||
test('Create desc gate: empty price still passes when other fields full', () => {
|
||||
// Price is publish-only; Create desc must not gate on it.
|
||||
assert.equal(canCreateDesc(full), true);
|
||||
assert.deepEqual(missingCreateDesc(full), []);
|
||||
});
|
||||
|
||||
test('Create desc gate: lists each missing field; no description or price key', () => {
|
||||
const miss = missingCreateDesc({
|
||||
...full,
|
||||
contentLlmEnabled: false,
|
||||
@@ -38,7 +43,6 @@ test('Create desc gate: lists each missing field; no description key', () => {
|
||||
figureTermIds: [],
|
||||
gradeTermId: '',
|
||||
moistureTermId: '',
|
||||
price: '',
|
||||
});
|
||||
assert.deepEqual(miss, [
|
||||
'content_llm',
|
||||
@@ -51,16 +55,15 @@ test('Create desc gate: lists each missing field; no description key', () => {
|
||||
'figure',
|
||||
'grade',
|
||||
'moisture',
|
||||
'price',
|
||||
]);
|
||||
assert.equal(miss.includes('description'), false);
|
||||
assert.equal(miss.includes('price'), false);
|
||||
const labels = missingCreateDescLabels({
|
||||
...full,
|
||||
figureTermIds: [],
|
||||
price: '',
|
||||
});
|
||||
assert.ok(labels.includes('≥1 figure'));
|
||||
assert.ok(labels.includes('price'));
|
||||
assert.equal(labels.includes('price'), false);
|
||||
});
|
||||
|
||||
test('Create desc gate: recomputes on field change (reactive-ready)', () => {
|
||||
|
||||
Reference in New Issue
Block a user