From d694ce81ed256c71cfea54136e4a87424cf17a34 Mon Sep 17 00:00:00 2001
From: Stefan <stefan@kaproblem.com>
Date: Thu, 27 Nov 2025 20:40:45 +0100
Subject: [PATCH] fix: Display mate scores correctly in move exchange analysis

When Stockfish detects a forced mate, it sets the mate field and resets
the score to 0. The previous code was showing '0 cp' which was misleading.

Changes:
- Format evaluation strings to show 'Mate in X' when mate is detected
- Only show delta (centipawn change) when neither position has a mate
- Update eval instruction to specifically mention mate situations
- Add explanation of mate notation in the prompt

Example output now:
- Pre-Eval: -326 cp
- Post-Eval: Mate in 3
(instead of showing '0 cp' which was confusing)
---
 src/components/Tutor.tsx | 32 +++++++++++++++++++++++++++-----
 1 file changed, 27 insertions(+), 5 deletions(-)

diff --git a/src/components/Tutor.tsx b/src/components/Tutor.tsx
index c32a0db..ac96904 100644
--- a/src/components/Tutor.tsx
+++ b/src/components/Tutor.tsx
@@ -152,6 +152,22 @@ CRITICAL RULES:
 
                 const delta = postScore - preScore;
 
+                // Format evaluation strings for display
+                let preEvalStr = "";
+                let postEvalStr = "";
+
+                if (preMate !== null) {
+                    preEvalStr = `Mate in ${preMate}`;
+                } else {
+                    preEvalStr = `${preScore} cp`;
+                }
+
+                if (postMate !== null) {
+                    postEvalStr = `Mate in ${postMate}`;
+                } else {
+                    postEvalStr = `${postScore} cp`;
+                }
+
                 // Check for significant change
                 let isSignificant = false;
 
@@ -163,7 +179,13 @@ CRITICAL RULES:
 
                 let evalInstruction = "";
                 if (isSignificant) {
-                    evalInstruction = `The evaluation changed SIGNIFICANTLY (Delta: ${delta} cp). You MUST comment on this shift in power and what caused it.`;
+                    if (preMate !== null || postMate !== null) {
+                        // Mate situation - explain the mate threat
+                        evalInstruction = `The evaluation involves MATE. You MUST comment on this critical situation and what caused it.`;
+                    } else {
+                        // Regular significant change
+                        evalInstruction = `The evaluation changed SIGNIFICANTLY (Delta: ${delta} cp). You MUST comment on this shift in power and what caused it.`;
+                    }
                 } else {
                     evalInstruction = "The evaluation change is MINOR/INSIGNIFICANT. Do NOT mention the score, 'advantage', or who is winning. Focus ONLY on the strategic purpose of the moves.";
                 }
@@ -267,10 +289,10 @@ Position Context:
 - FEN after my reply (current position): ${currentFen}
 
 My Internal Thoughts (Data):
-- Pre-Eval (Before User Move): ${preScore} cp
-- Post-Eval (After My Reply): ${postScore} cp
-- Delta: ${delta} cp
-(Note: Scores are from White's perspective. Positive = White advantage, Negative = Black advantage.)
+- Pre-Eval (Before User Move): ${preEvalStr}
+- Post-Eval (After My Reply): ${postEvalStr}
+${preMate === null && postMate === null ? `- Delta: ${delta} cp` : ''}
+(Note: Scores are from White's perspective. Positive = White advantage, Negative = Black advantage. "Mate in X" means forced mate in X moves.)
 
 ${tacticalInstruction}